Skip to content
This repository was archived by the owner on Jun 23, 2026. It is now read-only.

Update node.ts to handle non-string label data - #1281

Merged
Apollon77 merged 1 commit into
matter-js:mainfrom
mullender:patch-1
Dec 2, 2025
Merged

Apollon77 merged 1 commit into
matter-js:mainfrom
mullender:patch-1

Conversation

@mullender

Copy link
Copy Markdown
Contributor

As reported in home-assistant/core#156671 there is a case in which label is not a string but an object:

{
    "TLVValue": null,
    "Reason": "InteractionModelError: Failure (0x1)"
}

This then causes an error in the rendering of the dashboard.

Ideally we would figure out where the bad data comes from. But this should fix the symptom.

Comment thread dashboard/src/client/models/node.ts Resolved
@mullender

Copy link
Copy Markdown
Contributor Author

I updated the pull request with the suggested change

@mullender

Copy link
Copy Markdown
Contributor Author

It looks like this needs a label. Perhaps bugfix

@mullender

Copy link
Copy Markdown
Contributor Author

Is it possible to merge this, or are there more items I need to take care of? cc: @Apollon77

@Apollon77

Copy link
Copy Markdown
Contributor

Oh yeah sure, but release will take a bit

@Apollon77 Apollon77 added bugfix Pull request that fixes a (known) issue/bug frontend labels Dec 2, 2025
@Apollon77
Apollon77 merged commit 98f0635 into matter-js:main Dec 2, 2025
3 of 4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Pull request that fixes a (known) issue/bug frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants