Conversation
Adapting the processor to Monolog 3 introduced a use of Monolog\LogRecord, which this test asserts the full list of.
Six screenshots differ only by the Matomo 6 accent colour, synced from the CI artifacts of run 31569840370. The two GA4 import screenshots are deliberately not synced: on Matomo 6 the import form fails with a missing propertyId, which needs fixing first.
Vue's v-model does not receive jQuery's synthetic .val().change(), so on Matomo 6 the form submitted with an empty propertyId and no import was ever scheduled; the later spec steps failed on the missing import row.
Programmatically set values do not reach the Vue model even with native input/change events dispatched, while trusted typed input does (same pattern as the FormAnalytics specs).
The multituple scope select's option values still use the string: prefixed keys, and the radio needs waiting for before Vue mounts it.
…hots There has been no importer selection radio since GA3 was removed — the jQuery empty-set click just masked it, which is also why load_ga4 always equalled load. The six lifecycle screenshots are synced from the first run where the import flow actually executes on Matomo 6, each verified to show the correct import state.
Update the UI expected screenshots and specs for Matomo 6
…ignore_release] Submitting the form navigates, and .pageWrap is present before anything is rendered into it, so the capture was an empty 21px strip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Matomo 6 compatibility for GoogleAnalyticsImporter. One change would have been a fatal error, not a deprecation: the Monolog 3 processor signature.
What changed
5.2.1→6.0.0,require.matomo>=6.0.0-b1,<7.0.0-b1,composer.jsonPHP>=7.2.5→>=8.1.0, changelog entry.matomo6_*aliases, MySQL 8.0 / MariaDB 10.6 matrix, UI job Node 16 → 24.phpstan.yml/phpcs.ymlalready ran at or above 8.1 and are unchanged.phpVersion→80100;github-action-testsmarked(?). Under PHPStan 2 anexcludePathsentry matching nothing aborts the whole analysis, so this check was not actually running before.Arrayprop making every rowunknown, valuelesshref).@color-orange-brandwas dropped from Morpheus; replaced with its literal#f57c00. A missing Less variable breaks stylesheet merging outright.Worth a look — Monolog 3
LogToSingleFileProcessor::__invoke()tookarray $recordand mutated it. Monolog 3 passes an immutableLogRecord, so this would have been a fatal error rather than a deprecation warning. Rewritten to core's own shape (cf.Monolog/Processor/SprintfProcessor), using$record->with(message: …).6.x-devis 2 non-test commits behind5.x-dev(dependency security advisories, a translation). Needs a backport — not part of this PR.All commits are
[ignore_release]: compatibility only.Checklist