Update the UI screenshots for the report header actions menu - #122
Open
tzi wants to merge 8 commits into
Open
Conversation
Bump plugin version to 6.0.0 and require Matomo >=6.0.0-b1,<7.0.0-b1.
* Run plugin tests against MySQL 8.0 and MariaDB 10.6 The workflow inherited the shared action's MySQL 5.7 default, which is below Matomo's new minimum. Pin the database-backed jobs to the supported floor: PluginTests now runs a MySQL 8.0 + MariaDB 10.6 matrix, and the UI/JS jobs run on MySQL 8.0. * Only upload plugin test artifacts for the MySQL matrix leg PluginTests runs a MySQL + MariaDB matrix; the upload-artifacts condition matched both legs and uploaded twice. Restrict the upload to the MySQL leg.
… Puppeteer 24) (#114) * Update expected UI screenshots for the new headless Chrome (Node 24 / Puppeteer 24) * Update expected UI screenshots for the new headless Chrome (Node 24 / Puppeteer 24) * Re-sync expected UI screenshots for the new headless Chrome after rebase Rendering drift only (identical content, minor line-height/AA shifts) under the new headless Chrome used by the migrated screenshot-testing harness. * Run the plugin UI tests on Node 24 Match the Node 24 / Puppeteer 24 screenshot-testing stack; the UI job was still pinned to Node 16.
Teal brand screenshots on 6.x-dev plugin base; synced from matomo-org/matomo run 30405694397.
The DataTable search moved from the table footer into the shared ReportHeader (matomo-org/matomo#24986), which changes every report screenshot.
The report actions moved out of the icon bars around the table and into the single menu behind the report header's 3-dots trigger, so every report screenshot changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion to matomo-org/matomo#25064, which moves each report's actions out of the icon bars around the table and into the single menu behind the report header's 3-dots trigger. Every report screenshot changes as a result.
The screenshots here were produced by the core PR's own CI run, not locally.
Note on the base
This branch is built on the commit the core PR's base branch pins, which has diverged from
6.x-dev— it carries commits6.x-devdoes not, and the reverse is also true. That is expected in this series: the core-side PRs merge before their plugin-side counterparts. It will be rebased once the intervening plugin-side PRs land.Checklist