Repository navigation
feat: one-row phone header with a Meny, new-tab links and a one-line strip - #69
Merged
Merged
Conversation
The 2 x 2 grid used two fixed columns, so a one-word label overflowed its cell at a larger text size and printed over the next number. The columns now drop to one when two will not fit, and stay 2 x 2 at default size. Also checks 360 px in the header row rule, retitles the 200 % header test and removes a stale skip-link comment.
malinfossum
force-pushed
the
feat/phone-header
branch
from
October 12, 2026 14:41
e612d7e to
519989b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
#63 gave the phone a header of three rows (brand, pickers, links) and pinned the quick exit to the top right corner, with 10rem of room reserved for it in the header and the acute strip. At 320 px that was too tall, and the reserved room squeezed the strip to one number per row. This replaces it.
position: fixedany more, and the 10rem of reserved room is gone.<details>with three groups: the links (Alle tjenester, Helsenorge, NAV), Språk and Tema. The Språk and Tema groups carry visible labels, and every row shares one text edge and one check edge. Choosing a link closes it and puts focus back on the trigger. A theme row keeps focus and announces "Tema: Mørkt". It sits in its own "Hovedmeny" navigation, and only one of the two navigations is shown at any width, so a screen reader finds one landmark.rel="noopener noreferrer"and hidden text "(ekstern side, åpnes i ny fane)" / "(external site, opens in a new tab)". The quick exit is unchanged.scroll-padding-top(5rem) for the sticky header, so a focused element or an anchor never lands under it.(hover: hover) and (pointer: fine)), so a tap on a phone just dials.Red proofs
Every new or changed check failed once with the code broken on purpose, then passed after I restored it.
Unit tests, new-tab links and shared rows
target="_blank"removed from the external linkstargetattribute missingrel="noopener noreferrer"cut torel="noopener"noreferrermissingheader.externalback to the old text (en and nb)/Unit tests, the Meny
focusOnOpen: "active"announce(...)removedonFollowonly setsopen = false<nav>replaced by a<div>landmark-uniquearia-labelledbyremoved from either group.menu-wordspan removedsummary-nameaxe violationnav-linkonFollowremoved from the Menypageparam kept on a language row&page=2localStorage.setItemremovedheader-menylangremoved from the language rowslangheaderMenu.test.tsx(trigger name, hrefs, target, rel, aria-current, lang, group names, arrow wrap, theme applied, row pressed, landmark name, focus)Playwright, the header (320 to 1920)
.brand-word { display: none }removed.menu-nav { display: none }removed at 1024scroll-padding-topset to 0.menu-list .picker-checkrule removedflex-wrapremoved from the row.btn-secondary40 px.quick-exitshifted 6 pxmin-widthat 330 px and below.brand-wordgiven a 14 px left margin from 360 pxstaticmin-height40 px.header-toolsor.header-navnot hidden at 1023.header-navlaid out but empty.header-menuhidden instead of.menu-navat 1024usePickerdisabled.menu-listpushed 200 px rightaria-pressed, Escape, trigger focus)/om; Meny not closed after a linkopenassertions failedNot shown red. Two things could not be. First, the
.menu-nav { display: flex }safeguard: with today's markup the nav is 44 px tall asdisplay: blocktoo, so no break makes a check fail. Second, the Playwright assertion "Mørkt keeps focus after Enter" stays green withrow.focus()removed, because Chromium keeps focus on the button after Enter by itself. Therow.focus()is there for Safari clicks. The unit test covers that code path and goes red with its own break ("row keeps focus", focus moved to the summary instead).The acute strip
aria-labelremoved from the tel linksz-indexremoveddata-tips="hidden") disabledflex-wrapremoved from the stripChecks
npx biome ci .clean (one existing info about the schema version), 336 unit tests,npm run build:siteprerendered 210 pages, 119 Playwright tests (Playwright 1.64.0, Chromium 1248).Manual, before merge
/sokleaves NVDA on "Meny". Escape returns to "Meny".After merge, open
https://varde.pages.devon a phone and try the Meny, the exit and the strip in both languages.