Repository navigation
Start reverse text iteration at the logical cursor - #668
Open
ShahadatTest wants to merge 1 commit into
Open
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change
After a TextIOWrapper read, reverse_iter_lines(..., preseek=False) starts at the underlying read-ahead cursor, often EOF, instead of the wrapper's logical position. Synchronize the wrapper with its own tell/seek cookie before reading its binary buffer.
Six regressions fail before the change; controls cover zero position and the default preseek behavior. Tests cover UTF-8 and translated CRLF newlines, partial lines and newline boundaries. This is independent of #633's JSONL relative-seek alignment and #649's block-size validation.
Validation on Windows:
The backstory
Earlier contribution: #665. This was found during source inspection and controlled local probes; no personal application use or human review is claimed.
AI assistance
new 20ta koro(make 20 new contributions). Codex investigated the bug, checked existing work and policies, implemented and tested the change, and prepared this PR.