Repository navigation
Preserve sparse character positions in spooled text writes - #667
Open
ShahadatTest wants to merge 1 commit into
Open
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change
Seeking beyond EOF in SpooledStringIO updates tell() but leaves the backing byte cursor at EOF. Writing then appends immediately instead of preserving the NUL gap expected from StringIO. Count actual characters traversed and, when EOF is reached early, seek over the remaining single-byte NUL positions.
All seven regression cases fail against the unchanged production source. Tests use StringIO as the content/cursor reference and cover absolute/current/end-relative seeks, UTF-8 text, memory/disk storage, an empty read after seeking, and a sparse write that triggers automatic rollover. Nonzero relative seeks are an existing SpooledStringIO extension; their reference destination is calculated as an absolute StringIO seek.
This changes sparse seek positioning, independently of #624's length-query read-ahead bug and #630's write-after-read-ahead alignment. Different-width UTF-8 overwrites remain outside this patch.
Validation on Windows:
The backstory
Earlier contribution: #665. This was found during source inspection and controlled local probes; no personal application use or human review is claimed.
AI assistance
new 20ta koro(make 20 new contributions). Codex investigated the bug, checked existing work and policies, implemented and tested the change, and prepared this PR.