Repository navigation
Initialize BarrelList without truth-testing iterable inputs - #662
Open
Gambit-Checkmate wants to merge 1 commit into
Open
Gambit-Checkmate wants to merge 1 commit into
Gambit-Checkmate wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change
Closes #660.
Treat None as the omitted iterable rather than truth-testing every input. BarrelList currently silently drops a false-valued iterable's contents and rejects a valid iterable whose truth value is ambiguous. Iteration itself now determines contents, as for builtin list. Existing explicit-None behavior remains empty; invalid false non-iterables such as 0 now raise TypeError.
Three regressions fail before the change: nonempty false-valued iterable, ambiguous-truth iterable, false non-iterable. Four controls cover None and empty list/tuple/iterator. This does not alter pending #617's copy/pickle reduction or #613's insertion normalization.
Validation on Windows / CPython 3.13.13:
The backstory
Previous contribution #601 was acknowledged and incorporated in #609. This follow-up came from inspecting current master and comparing documented container behavior with builtin containers, not personal production usage. Existing related contributions were checked before filing the linked issue.
AI assistance
Hosted CI: Actions run 40424154552 is
action_requiredfor external-contribution approval. No hosted tests have executed for this head.