Repository navigation
feat(engine): flag new Error(...) statements missing throw - #185
Merged
Merged
Conversation
Folded into the discarded-return-value diagnostic. Corpus: 23 hits,
21 in node benchmark/fs (default: new Error('Invalid type')).
Claude-Session: https://claude.ai/code/session_01W9Mk18mBNfkPfgg3hYweKq
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
new XError(...)expression statements (constructor name ending in Error/Exception) to the discarded-return-value diagnostic. Corpus run: 23 hits, 21 in nodebenchmark/fswheredefault: new Error('Invalid type')never throws. Fixture covers hit (ConfigError) and misses (thrown ParseError, non-error Widget); breaking the check fails the fixture.https://claude.ai/code/session_01W9Mk18mBNfkPfgg3hYweKq