feat(vcluster-release): add single release dispatcher action#162
Open
sydorovdmytro wants to merge 1 commit into
Open
feat(vcluster-release): add single release dispatcher action#162sydorovdmytro wants to merge 1 commit into
sydorovdmytro wants to merge 1 commit into
Conversation
5d32634 to
223d51a
Compare
One entry point for cutting a vCluster release on any supported line. Routes by numeric era compare against the v0.36 cutover: legacy (< v0.36) fans out to both loft-sh/vcluster and loft-sh/vcluster-pro (OSS first), monorepo (>= v0.36) dispatches loft-sh/vcluster-pro only. Creates the tag(s) and dispatches each line's own release.yaml via workflow_dispatch; the GitHub Release is a pipeline output, not a trigger. Named per-product (vcluster-release) since this shared repo releases multiple products. See DEVOPS-1050.
675bf3d to
11c6416
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vcluster-releasecomposite action: one entry point for cutting a vCluster release on any supported line, so nobody has to remember which release procedure a version needs.vcluster-release, notcut-release) since this shared repo releases multiple products and the action is vcluster-specific (hardcodesloft-sh/vcluster+loft-sh/vcluster-proand thev0.36cutover). Leaves room for e.g.platform-releaselater.(major, minor)compare against thev0.36cutover: legacy (< v0.36) fans out to bothloft-sh/vclusterandloft-sh/vcluster-pro(OSS first); monorepo (>= v0.36) dispatchesloft-sh/vcluster-proonly.release.yamlviaworkflow_dispatch(gh workflow run --ref <tag>, which runs the tagged commit's version). The GitHub Release is a pipeline output, not a trigger — so a monorepo-created OSS release can't re-trigger the OSS builder.dry-rundefault that still runs the read-only routing checks.Test plan
make test-vcluster-release— 26 bats cases: pure routing (parse_major_minor/derive_line/classify_eraincl. numericv0.9 < v0.36andv1.0boundary), legacy dispatch order (OSS before pro), double-cut guards, monorepomainfallback, and the 404-vs-transient distinction (stub mirrors realghexiting non-zero on 404).make lint(actionlint + zizmor, whole repo) clean;make check-docsup to date.v0.35.99routes OSS→pro; monorepov0.36.99falls back tomain; the double-cut guard correctly refused a real existing release.Notes
unpinned-useszizmor finding on the siblingsemver-validationreference is expected (internal action pinned by SHA + tag comment per this repo's convention).workflow_dispatchbutton inloft-sh/vcluster-pro(separate PR, held until this merges andvcluster-release/v1is tagged).References DEVOPS-1050