Skip to content

(prototype) Delete the four old SimCLR copies - #2039

Draft
gabrielfruet wants to merge 1 commit into
simclr-v2-06-example-benchmark-gatefrom
simclr-v2-07-delete-old-copies
Draft

(prototype) Delete the four old SimCLR copies#2039
gabrielfruet wants to merge 1 commit into
simclr-v2-06-example-benchmark-gatefrom
simclr-v2-07-delete-old-copies

Conversation

@gabrielfruet

@gabrielfruet gabrielfruet commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Prototype. Do not merge. This is a design exploration for the LightlySSL 2.0
refactor, opened to be read and argued with, not to land on master. The whole
stack goes together or not at all, and the shape is still open.

7 of 7 in a stack. Base: #2038.

Removes the four SimCLR implementations that PR 6 replaces:

examples/pytorch/simclr.py
examples/pytorch_lightning/simclr.py
examples/pytorch_lightning_distributed/simclr.py
benchmarks/imagenet/resnet50/simclr.py

plus their generated notebooks and the METHODS entry in the ResNet-50 runner. dcl.py and dclw.py import SimCLRTransform directly rather than the deleted module, so they keep working.

docs/source/examples/simclr.rst loses its three tabs for one literalinclude of the new example, and gains a section on reproducing a published number.

The README's 63.2 linear and 73.9 kNN came from the file being deleted here, on the run logged as imagenet_resnet50_simclr_2023-06-22_09-11-13. The number stays in the table with a footnote saying which file produced it and that the new benchmark has not reproduced it. benchmarks/simclr/README.md lists the three things that differ: batch size and learning-rate scaling, the online probe's inputs and optimiser, and the kNN probe's lifecycle.

Testing: make generate-example-notebooks produces no diff, and nothing in docs/ or README.md still points at a deleted path.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 39228a7bb5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +17 to +19
> SimCLR has moved to [benchmarks/simclr/](../simclr), which carries one row per
> dataset and is gated against `examples/simclr.py`. The rest of this tree follows
> as each method is ported.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove SimCLR from the old benchmark inventory

After moving SimCLR out of this tree, the Available Benchmarks table still advertises it under resnet50/. Users following that inventory and passing --methods simclr to this README's resnet50/main.py command will get a KeyError, because the SimCLR file was deleted and METHODS no longer contains that key. Update the inventory alongside this move.

Useful? React with 👍 / 👎.

@gabrielfruet gabrielfruet changed the title Delete the four old SimCLR copies (prototype) Delete the four old SimCLR copies Aug 16, 2026
@gabrielfruet
gabrielfruet marked this pull request as draft August 16, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant