Interview: separate inferred assumptions from confirmed requirements at handoff (#275) - #279
Conversation
리뷰 · 우선순위 42 / 80이 PR은 인터뷰가 Plan으로 넘어갈 때 “AI가 짐작한 것”과 “사용자가 동의한 것”이 같은 문장처럼 보이던 문제를 고치려는 문서(가이드) 변경입니다. 코드·스키마·훅은 안 건드리고, Interview 스킬에 라인 - 메인테이너의 판단이 필요한 지점 트래커에 남은 resolved 항목이 freeze에서 open으로 다시 실리는 구멍을, 이번 가이드 PR에서 “Plan이 권위”로 받아들여 닫을지, 아니면 freeze/트래커 정리 규칙을 후속 이슈(#275 스키마 단계)로 명시할지. 또한 E7만으로 #275를 “closes”할지, 아니면 “guidance landed; schema/enforcement follow-up”으로 이슈를 열어 둘지. 너의 추천
이 댓글은 grok-bot이 작성했습니다 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e7bd3eb41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - High-impact `proposed` assumptions (INTERVIEW-ASSUME-01) are candidates for the | ||
| next relevant question round. Low-impact ones may stay `proposed`; closeout lists them. |
There was a problem hiding this comment.
Require high-impact assumptions to be asked
When a proposed assumption's if wrong consequence changes scope, design, or verification, calling it merely a “candidate” permits the agent to skip it and proceed to Plan on a materially unconfirmed premise; the readiness rules allow recorded assumptions through. This also weakens the accepted D20 contract in devlog/_plan/260930_issue_train/002_architect_consultation.md:28, which says high-impact proposals are asked next. Make the next relevant question round mandatory for these assumptions rather than optional.
Useful? React with 👍 / 👎.
| `text` repeats the plan line without that `- `, and only `proposed` or `open` | ||
| entries belong there. Do not hand-edit session state; if a tracker entry | ||
| cannot be moved after it is resolved, the plan line's status is authoritative. |
There was a problem hiding this comment.
Prevent resolved tracker entries from freezing as open
When an assumption already exists in the Interview tracker and is subsequently confirmed or rejected, this fallback changes only the plan line and leaves the recorded tracker entry in place. freeze-cli.ts:97 nevertheless copies every recorded tracker assumption into evidenceBundle.openAssumptions, so the resulting freeze manifest still presents the resolved item as open and contradicts the authoritative plan. The workflow needs a supported way to retire or replace the tracker entry, or freeze must derive/filter its open assumptions from the resolved plan state.
Useful? React with 👍 / 👎.
Problem
Interview carried every unresolved item to Plan under one heading,
OPEN ASSUMPTIONS, so an inference the assistant made read the same as a constraint the user agreed to (#275). Nothing recorded where an assumption came from, how sure it was, or what changes if it is wrong.Change
Guidance only, in the Interview skill (new rule INTERVIEW-ASSUME-01):
source(apath:lineor the Q/A ledgereventIdof the user's answer),confidenceandif wrong.proposed,open,user_confirmedoruser_rejected. The last two require the answer'seventId; a reply typed in chat is confirmed through the next question round or keptopen.## OPEN ASSUMPTIONS(proposed and open only),## CONFIRMED REQUIREMENTSand## ASSUMPTION DECISIONS(rejected, kept as a decision trace). Becausecxc freezecopies recorded tracker assumptions into the manifest as open, only proposed and open entries belong in the tracker.proposedassumptions are asked in the next relevant round. Before I -> P, the closeout summary lists confirmed requirements separately from the remaining open ones.references/mind-dispatch.mdandloop/references/durable-goalplan.mdare synced.No code, schema, hook or runtime text changes. Existing trackers and freeze manifests read as before. The structured assumption schema the issue mentions as future work is not part of this change.
Verification
rg -c INTERVIEW-ASSUME-01: 4, 1, 1). Two reviewers checked every factual claim againstfreeze-cli.ts,interview-ledger.tsandinterview.ts, and one did a fresh-reader pass whose stumbles led to the clarified wording.npm test(3730 tests, 0 failures), inventory,gate.mjsandplatform-smoke.mjspass undercxc receipt test. The hook diff is empty.eventIdagainst the ledger.Refs #275. This closes by hand after merge because
devis not the default branch.