chore: format codebase with prettier#1100
Conversation
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
There was a problem hiding this comment.
Code Review
This pull request applies comprehensive formatting and style updates across numerous Markdown, SCSS, JavaScript, and YAML files to enforce consistency. A critical issue was found in assets/scss/_elements_project.scss where the border-top and border-bottom properties were wrapped in quotes, which makes them invalid CSS/SCSS and prevents the borders from rendering.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
🚀 Preview deployment: https://docs.layer5.io/pr-preview/pr-1100/
|
Signed-off-by: Aamod007 <aamodkumar2006@gmail.com>
Signed-off-by: Aamod007 <aamodkumar2006@gmail.com>
76e95fb to
2c572c9
Compare
|
@sudhanshutech , could you please take a look and review it when you have a chance? |
|
@Aamod007 @rishiraj38 Given that this change affects 1,300+ files, do we need a repository wide formatting pass right now? |
|
@NSTKrishna I think it's better to just rip the band-aid off now. Issue #1015 specifically asked for a repo-wide pass to finally get a baseline established.If we don't do it all at once, future feature PRs are just going to get bloated with random formatting changes every time someone saves a file in their IDE. Once we merge this, we can enforce it in CI and never have to worry about messy styling diffs again. I know it's going to cause some merge conflicts for open PRs right now, but it permanently solves the tech debt. |
|
@Aamod007 i suggest you to put this into Website Meeting |
Description
This PR resolves Issue #1015 by applying the configured Prettier code formatter across the entire repository. A code formatter was previously introduced in PR #947, but this is the first time it has been executed globally to bring all existing files up to standard.
Changes Made
make formatcommand (which runsnpm run format/prettier --write .)..prettierignoreconfiguration, ensuring that:public/,resources/) remain untouched.node_modules/) are ignored.layouts/) are excluded to prevent breaking Go template syntax.Rationale
Running the formatter on the entire codebase at once eliminates tech debt related to styling inconsistencies. It establishes a unified, clean code style moving forward and prevents tedious, incremental styling debates on future PRs.
Verification
npm run formatscript..prettierignorewere correctly skipped during the execution.Closes #1015