Repository navigation
8.0 cleanup: remove deprecated APIs and tidy the public surface - #271
Merged
Merged
Conversation
…lign live activity Sendable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking cleanup for 8.0, alongside #270.
Removed deprecated APIs:
APNSEnvironment.sandbox. Use.development.P256.Signing.PrivateKey.loadFrom(string:). Useinit(pemRepresentation:).sendWidgetsNotification(notification:deviceToken:). UsesendWidgetsNotification(_:deviceToken:).APNSError.ErrorReason.badEnvironmentKeyInToken. Apple doesn't document this reason; a response carrying it now decodes as.unknown("BadEnvironmentKeyInToken").Other cleanup:
APNSClientandAPNSBroadcastClientdefaulteventLoopGroupProviderto.shared(MultiThreadedEventLoopGroup.singleton). The README and DocC examples no longer recommend the deprecated.createNew.APNSExampleis no longer exported as a product, so dependents don't see it. The target stays, andswift run APNSExamplestill works in this repo.sendLiveActivityNotificationnow spells outContentState: Encodable & Sendable, matching the notification type and the other send methods. This isn't source-breaking, because the notification type already required it.All 162 tests pass.