Repository navigation
Add MDM notifications - #268
Merged
Merged
Conversation
Models the {"mdm": PushMagic} payload from Apple's device management
protocol with a sendMDMNotification method. The topic is the UID from the
MDM push certificate's subject, so there is no appID convenience.
# Conflicts: # Tests/APNSTests/APNSClientIntegrationTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APNSPushType.mdmhad no notification model or send method. This was deferred from the July parity audit because the payload is documented in the device management protocol rather than the push notification docs.What changed
APNSMDMNotificationencodes{"mdm": "<PushMagic>"}with noapskey, exactly as Apple's Sending MDM commands to a device specifies. The topic is the UID from the subject of the MDM push certificate, so there is only atopic:init and noappID:convenience.sendMDMNotification(_:deviceToken:)onAPNSClientProtocol.The test server already accepted
mdmwith no topic suffix requirement, so no server changes.Tests
Encoding test and an integration test through the test server.
162 tests, 0 failures.