copy the caller buffer before in-place moves in zip_files_move#443
Merged
kuba-- merged 1 commit intoJul 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In-memory delete mode shifts surviving entry data straight through the caller-owned stream buffer:
On a read-only backing (const/.rodata/PROT_READ mmap) that memmove is a write-through-const fault; on a writable buffer it silently mutates the caller's original bytes. Copy into a library-owned block on the first move, matching zip_stream_delete_write_func, so zip_stream_close frees it. Added test_entries_delete_stream_buffer_untouched (fails on master, passes here).