Conversation
`norm_new` in `NewtonSolve` was not accumulating on each inner loop iteration and wasn't being reset to zero between outer loop iterations. Fixed both issues. Also added a test that catches this bug. Signed-off-by: Robert Caddy <rcaddy@princeton.edu>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
norm_newinNewtonSolvewas not accumulating on each inner loop iteration and wasn't being reset to zero between outer loop iterations. Fixed both issues.This was causing an issue when I was using the solver. I'm solving a system of ODEs as part of a larger time step and if I varied the sizes of the larger time steps but evolved to the same time it would cause significant differences in the results.
Previous PRs
This was previously posted in PR #3276 and reverted in PR #3304 due to some failing tests I couldn't reproduce. Hopefully once PR #3262 is merged this will pass the tests