Repository navigation
Serve filesystem-storage attachments from the kpi nginx sidecar - #123
Merged
Merged
Conversation
ScottMillard
requested review from
olive-KTB
and
a balanced review from Copilot
October 7, 2026 21:44
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The feature must use a minor version according to the repository’s documented SemVer policy.
2 open findings
What changed in this PR
Adds filesystem-backed KPI attachment serving through the nginx sidecar.
Changes:
- Adds configurable protected-media aliasing and sidecar volume mounts.
- Adds Helm unit tests for default and configured behavior.
- Updates chart version and changelog.
| File | Description |
|---|---|
values.yaml |
Defines protected-media and sidecar mount values. |
templates/kpi/deployment.yaml |
Mounts configured media volumes in nginx. |
files/kpi/nginx.conf.tpl |
Adds the internal /protected/ location. |
tests/kpi_nginx_protected_media_test.yaml |
Tests nginx configuration and mounts. |
tests/values/required.yaml |
Supplies required test values. |
Chart.yaml |
Updates the chart version. |
CHANGELOG.md |
Documents the feature. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
| @@ -1,3 +1,6 @@ | |||
| # 7.0.5 | |||
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 7.0.0 | ||
| version: 7.0.5 |
ebr-ICRC
force-pushed
the
feature/nginx-protected-media
branch
2 times, most recently
from
October 8, 2026 12:08
f087b41 to
a4a40e0
Compare
olive-KTB
previously approved these changes
Oct 8, 2026
ebr-ICRC
force-pushed
the
feature/nginx-protected-media
branch
from
October 9, 2026 08:43
a4a40e0 to
fea1465
Compare
This was referenced Oct 9, 2026
Contributor
|
@ebr-ICRC Please resolve merge conflicts |
With filesystem storage, KPI answers attachment downloads with X-Accel-Redirect to /protected/..., but the sidecar had no such location and could not mount the media volume. Add nginx.extraVolumeMounts and kpi.nginx.protectedMediaPath, which renders an internal /protected/ location. Defaults render unchanged. Fixes kobotoolbox#115 Co-Authored-By: Claude <noreply@anthropic.com>
ebr-ICRC
force-pushed
the
feature/nginx-protected-media
branch
from
October 12, 2026 13:39
fea1465 to
898417b
Compare
Contributor
Author
|
@olive-KTB Conflicts resolved: rebased on main (after #122), chart version is now 7.2.0. |
olive-KTB
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115
With filesystem storage, KPI answers attachment downloads with
X-Accel-Redirect: /protected/<path relative to KOBOCAT_MEDIA_ROOT>(kobo/apps/openrosa/apps/logger/models/attachment.py). The sidecar had no/protected/location and could not mount the media volume.nginx.extraVolumeMounts(default[]): extra mounts for the sidecar, using volumes fromkpi.extraVolumes.kpi.nginx.protectedMediaPath(default empty): when set, renderslocation /protected/ { internal; alias <path>/; }, matching kobo-docker.main. Validated withnginx -tonnginx:1.31.tests/), see Unit tests for templates (helm-unittest) #118.