#2174 feat: add default do not remap preference#2178
Open
keymapper-ai wants to merge 1 commit into
Open
Conversation
Add a "Do not remap by default" toggle to the Change Default Options settings page. When enabled, new trigger keys will have consumeEvent = false by default, letting the original key event pass through to other apps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2174.
Adds a "Do not remap by default" toggle to the Change Default Options settings page (
Settings → Change default options). When enabled, new trigger keys added to a key map will have consumeEvent = false by default — meaning the original key event is passed through to other apps rather than being consumed by Key Mapper.Changes
data/Keys.kt— addsdefaultDoNotRemapboolean DataStore key (pref_default_do_not_remap)data/PreferenceDefaults.kt— addsDO_NOT_REMAP = falsedefault constantGetDefaultKeyMapOptionsUseCase— exposesdefaultDoNotRemap: StateFlow<Boolean>backed by the new preference keySettingsViewModel— extendsdefaultSettingsScreenStatevia a nestedcombineto includedoNotRemap; addsonDefaultDoNotRemapChangedcallback override; addsdoNotRemapfield toDefaultSettingsStateDefaultOptionsSettingsScreen— adds aSwitchPreferenceComposefor the new preference andonDefaultDoNotRemapChangedtoDefaultOptionsSettingsCallbackConfigTriggerDelegate— addsdefaultDoNotRemap: Boolean = falseparameter to bothaddKeyEventTriggerKeyandaddEvdevTriggerKey; uses it as the initial value ofconsumeEvent(modifier keys still force it tofalseregardless)ConfigTriggerUseCase— passesdefaultDoNotRemap.valuefromGetDefaultKeyMapOptionsUseCaseto the delegate when adding new trigger keysstrings.xml— addstitle_pref_default_do_not_remapandsummary_pref_default_do_not_remapCHANGELOG.md— adds entry under 4.2.0 AddedGenerated by Claude Code