maint: move to PHP 8.4, Apache 2.4.68 馃崚 - #211
Merged
Merged
Conversation
Detail in keymanapp/keyman.com#828. Changes required: * move from PHP 7.4 to PHP 8.4 Docker image (upgrades Debian, Apache, PHP as major components) * dependency upgrades forced for phpunit * addition of BCTLS flag to .htaccess mod_rewrite rules (https://stackoverflow.com/q/75684314/1836776) See-also: keymanapp/keyman.com#828 See-also: keymanapp/s.keyman.com#1712 Relates-to: #209 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
commented
Sep 10, 2026
| # Keymanweb.com 2.0 rewrite rules for Keymanweb.com 1.0 /go/lang/kbd urls | ||
|
|
||
| # Rewrite /go/lang/kbd/app[?...] to /?kmwlang=lang,kmwkbd=kbd | ||
| RewriteRule "^go/([^/]+)/([^/]+)/([^?]+)(\?)?(.+)?$" "/index.php?kmwlang=$1&kmwkbd=Keyboard_$2&$5" |
Member
Author
There was a problem hiding this comment.
This rule is not actually correct - the query string does not get matched in the left hand part of the rule so everything from (\?)? onwards there is nonsense.
[BCTLS] technically not needed either because we only allow 'safe' chars in lang and kbd ids, but it doesn't hurt.
For future follow-up (see #212)
tim-eves
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detail in keymanapp/keyman.com#828.
Changes required:
Cherry-pick-of: #210
See-also: keymanapp/keyman.com#828
See-also: keymanapp/s.keyman.com#1712
Relates-to: #209
Test-bot: skip