Skip to content

fix(developer): trim new words entered into the wordlist editor - #16538

Open
mcdurdin wants to merge 1 commit into
masterfrom
fix/developer/12668-trim-new-words-in-wordlist-editor
Open

fix(developer): trim new words entered into the wordlist editor#16538
mcdurdin wants to merge 1 commit into
masterfrom
fix/developer/12668-trim-new-words-in-wordlist-editor

Conversation

@mcdurdin

@mcdurdin mcdurdin commented Sep 7, 2026

Copy link
Copy Markdown
Member

Fixes: #12668

User Testing

  • TEST_WORDLIST_EDITOR: Open the Wordlist Editor and try entering spaces into new rows in the editor. Upon exiting the cell, the text should be trimmed, and if only whitespace was present on the last row, it should return to being a 'Add word...' entry. Other words entered should also be trimmed of leading and following whitespace.

@github-project-automation github-project-automation Bot moved this to Todo in Keyman Sep 7, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added has-user-test user-test-required User tests have not been completed labels Sep 7, 2026
@keymanapp-test-bot

keymanapp-test-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

User Test Results

Test specification and instructions

Test Artifacts

Comment on lines +331 to +332
// And if the last row was just whitespace, show the hint text again
FillGridNewRow;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we check that the new last row is also not just whitespace? Is that "edge case" enough that we don't care? Or is there some mechanism I'm not seeing that handles such a case?

@Meng-Heng

Meng-Heng commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Test Specs

  1. Keyman Developer 19.0.281-alpha-test-16538

Test Results

  • TEST_WORDLIST_EDITOR (PASSED):
  1. Launch Keyman Developer -> Open a wordlist project
  2. Enter new words algelo + space
  3. Click out of the cell
  4. VERIFIED: The space is trimmed
  5. Enter Spaces before and after the words
  6. VERIFIED: The spaces are trimmed
  7. Add just spaces to the last row
  8. VERIFIED: The last row shows "Add word..."

@keymanapp-test-bot keymanapp-test-bot Bot removed the user-test-required User tests have not been completed label Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

bug(developer): A new "Add word" row is created by pressing the spacebar.

4 participants