change(developer): move touch layout editor to typescript by mcdurdin · Pull Request #16520 · keymanapp/keyman

mcdurdin · 2026-09-03T14:40:26Z

A change in ~~three~~five commits. It will be easiest to review these changes commit-by-commit and with whitespace changes ignored.

31999ce: Minimal changeover to esm, use tsc to build. Builds and runs. Installer will still include source files and the editor should be moved outside of the xml/ folder later.
173e2ec: Rename touch layout editor .js to .ts - note: doesn't build, just for history, and simplicity of review.
c1abf5f: Make minimal changes to Touch Layout Editor source files in order to build with Typescript with noImplicitAny=false (to be cleaned up later). Also make source files accessible through the web server for Developer Console use.
d86b2b5: moves jquery and jqueryui out of node_modules, due to implicit import conflicts in other Typescript modules in /web (long term resolution proposed in maint(common): consider declaring used types/libs in each tsconfig.json #16535)
98fee32: fixup initialization order for constants (triggered by recent change fix(developer): remember presentation and layer when switching platforms in touch layout editor #16509, which prompted the refactor when it was merged into this branch)

User Testing

TEST_REGRESSION: Open the touch layout editor, press F12 to view Developer Console. Run through all the standard operations of the touch layout editor and verify no errors in Developer Console and that all operations work correctly.

Things to test:

edit key properties
add/delete keys, rows, layers, platforms, flicks, longpress, multitap etc
drag + drop keys to rearrange
drag + drop characters from character map

You may wish to compare behaviour against the existing alpha release version.

keymanapp-test-bot · 2026-09-03T14:40:35Z

User Test Results

Test specification and instructions

🟥 TEST_REGRESSION (FAILED) (notes)

Retesting Template

Test-bot: retest TEST_REGRESSION

Test Artifacts

Developer
Keyboards
- Test Keyboards

Minimal changeover to esm, use tsc to build. Builds and runs. Installer will still include source files and the editor should be moved outside of the xml/ folder later.

Note: doesn't build, just for history

Make minimal changes to Touch Layout Editor source files in order to build with Typescript with noImplicitAny=false (to be cleaned up later). Also make source files accessible through the web server for Developer Console use.

Take the @types/jquery and @types/jqueryui packages out of the devDependencies and place the index.d.[c]ts files into the ext folder. This is needed because of fragility elsewhere with implicitly imported types, which is described for resolution in #16535. Keeping this as a separate commit as preference would be to have these dependencies managed through npm long-term. See-also: #16535

…ayout editor In order to resolve initialization order (see instigating property `builder.lastPresentations`), split all constants into a separate object `builderConstants`, inverting the dependency, which is both cleaner and the first step of removing the multi-module initialization of a single `builder` variable.

mcdurdin · 2026-09-07T05:23:50Z

Unused source file, detected during renames

Meng-Heng · 2026-09-09T05:57:03Z

Test Specs

Keyman Developer 19.0.281-alpha-test-16520

Test Results

TEST_REGRESSION (FAILED):

Open the touch layout editor
Press F12 to view Developer Console
Drag and drop from character map does not work
Remove 'symbol' layer shows errors
After removing the layer but it did not delete, switching the platform and layer had stopped working
Drag and move keys around does not work

jahorton

LGTM. Might want to fix or explicitly defer the TODO entries, though.

jahorton · 2026-09-11T13:44:04Z

 KEYMANCORE_PDB=keymancore-2.pdb

+function do_build_touch_layout_editor() {
+  # TODO: this could be a configure step but leaving it here while changes are in flux


I assume there is a plan to handle these TODOs in a separate PR, given they're still in the incoming changeset?

jahorton · 2026-09-11T13:44:16Z

+  # todo: make this an internal dependency
+  do_build_touch_layout_editor


jahorton · 2026-09-11T13:47:36Z

 begin
  doc := ARequestInfo.Document;
-  if doc.StartsWith('/app/source/toucheditor/lib/') and (Pos('..', doc) = 0) then
+  if doc.StartsWith('/app/source/toucheditor/src/') and (Pos('..', doc) = 0) then
  begin
-    Delete(doc, 1, Length('/app/source/toucheditor/lib/'));
+    Delete(doc, 1, Length('/app/source/toucheditor/src/'));
    RespondFile(GetLayoutBuilderPath + 'src/' + doc, AContext, ARequestInfo, AResponseInfo);
  end
+  else if doc.StartsWith('/app/source/toucheditor/lib/') and (Pos('..', doc) = 0) then
+  begin
+    Delete(doc, 1, Length('/app/source/toucheditor/lib/'));
+    RespondFile(GetLayoutBuilderPath + 'build/' + doc, AContext, ARequestInfo, AResponseInfo);
+  end


Seems a touch WET, but I do see the distinction between src/ and build/ for the RespondFile statements.

Furthermore, it appears that the lib entries refer to the built versions of the TS files? Basically, anything with a lib path redirects to the TS build output?

The new src entries thus refer to the original, foundational TS source, then?

github-project-automation Bot added this to Keyman Sep 3, 2026

github-project-automation Bot moved this to Todo in Keyman Sep 3, 2026

keymanapp-test-bot Bot added has-user-test user-test-required User tests have not been completed labels Sep 3, 2026

github-actions Bot added developer/ developer/ide/ change Minor change in functionality, but not new labels Sep 3, 2026

keymanapp-test-bot Bot added this to the B19S1 milestone Sep 3, 2026

mcdurdin marked this pull request as draft September 3, 2026 14:40

github-actions Bot added web/ web/predictive-text/ labels Sep 4, 2026

mcdurdin force-pushed the change/developer/touch-layout-editor-typescript branch 3 times, most recently from b5f6a2b to 321c0fa Compare September 5, 2026 03:55

mcdurdin mentioned this pull request Sep 5, 2026

maint(common): consider declaring used types/libs in each tsconfig.json #16535

Open

mcdurdin force-pushed the change/developer/touch-layout-editor-typescript branch 2 times, most recently from 5d01473 to 0fb009b Compare September 7, 2026 04:33

mcdurdin force-pushed the change/developer/touch-layout-reorganize-files branch from 2d198a3 to 76b36e8 Compare September 7, 2026 04:35

mcdurdin added 4 commits September 7, 2026 06:35

change(developer): convert layout editor to esmodules and tsc build

31999ce

Minimal changeover to esm, use tsc to build. Builds and runs. Installer will still include source files and the editor should be moved outside of the xml/ folder later.

change(developer): rename touch layout editor .js to .ts

173e2ec

Note: doesn't build, just for history

change(developer): move touch layout editor to typescript

c1abf5f

Make minimal changes to Touch Layout Editor source files in order to build with Typescript with noImplicitAny=false (to be cleaned up later). Also make source files accessible through the web server for Developer Console use.

mcdurdin force-pushed the change/developer/touch-layout-editor-typescript branch from 0fb009b to d86b2b5 Compare September 7, 2026 04:50

mcdurdin commented Sep 7, 2026

View reviewed changes

mcdurdin requested review from ermshiperete, jahorton and rc-swag September 7, 2026 06:04

mcdurdin marked this pull request as ready for review September 7, 2026 06:04

keymanapp-test-bot Bot added user-test-failed and removed user-test-required User tests have not been completed labels Sep 9, 2026

jahorton approved these changes Sep 11, 2026

View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

change(developer): move touch layout editor to typescript - #16520

change(developer): move touch layout editor to typescript#16520
mcdurdin wants to merge 5 commits into
change/developer/touch-layout-reorganize-filesfrom
change/developer/touch-layout-editor-typescript

mcdurdin commented Sep 3, 2026 •

edited

Loading

Uh oh!

keymanapp-test-bot Bot commented Sep 3, 2026 •

edited

Loading

Uh oh!

mcdurdin Sep 7, 2026

Uh oh!

Meng-Heng commented Sep 9, 2026 •

edited

Loading

Uh oh!

jahorton left a comment

Uh oh!

jahorton Sep 11, 2026

Uh oh!

jahorton Sep 11, 2026

Uh oh!

jahorton Sep 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		# todo: make this an internal dependency
		do_build_touch_layout_editor

Uh oh!

Uh oh!

Conversation

mcdurdin commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User Testing

Uh oh!

keymanapp-test-bot Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User Test Results

Test Artifacts

Uh oh!

mcdurdin Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

Meng-Heng commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Specs

Test Results

Uh oh!

jahorton left a comment

Choose a reason for hiding this comment

Uh oh!

jahorton Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

jahorton Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

jahorton Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mcdurdin commented Sep 3, 2026 •

edited

Loading

keymanapp-test-bot Bot commented Sep 3, 2026 •

edited

Loading

Meng-Heng commented Sep 9, 2026 •

edited

Loading