fix(web): support autocorrection of transposed text - #16450
Open
jahorton wants to merge 5 commits into
Open
Conversation
keymanapp-test-bot
Bot
added
the
user-test-missing
User Test ResultsTest specification and instructions Retesting TemplateTest Artifacts |
keymanapp-test-bot
Bot
added
has-user-test
user-test-required
mcdurdin
approved these changes
Aug 28, 2026
Co-authored-by: Marc Durdin <marc@durdin.net>
Contributor
Test Specs
Test Results
Screen.Recording.2026-09-01.at.11.25.01.in.the.morning.mov
|
keymanapp-test-bot
Bot
added
user-test-failed
and removed
user-test-required
Base automatically changed from
change/web/narrow-autoselection-comparisons
to
master
September 3, 2026 13:16
…tocorrect' into fix/web/support-transposition-autocorrect
Contributor
Author
|
OK, I've made some adjustments. Mind giving it a retry? Test-bot: retest TEST_TEH |
keymanapp-test-bot
Bot
added
user-test-required
Contributor
Test Specs
Test Results
Screen.Recording.2026-09-08.at.4.01.30.in.the.afternoon.mov |
keymanapp-test-bot
Bot
added
user-test-failed
and removed
user-test-required
Contributor
Author
|
I am unable to reproduce the effects you're seeing when using the downloaded artifact when emulating the test device you mentioned on my Mac. (Predictive-text won't even run properly, with errors being thrown!) Interestingly, it seems to operate fine when emulating it on Windows... and only then do I see the issue. Targeting a more up-to-date Android device seems to work much better. Could you retest against an API 32 (or more recent) Android device and see if the same issue reproduces then? |
Contributor
|
That's interesting to know, Josh. I'll try it out on a new API, and a physically device, if needed. |
Contributor
Test Specs
Test Results
Test Specs
Test Results
I'll try testing on Windows one more time, and then move to a physical device. Update: It's showing the same behavior and result on Windows Android Studio. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #16398
Fixes: #16399
Fixes: #12311
Note: will not handle transpositions that cross token boundaries.
Also note: major changes will be needed for epic/boundary-correction, as it will discontinue use of the LegacyQuotientSpur type.
Build-bot: skip release:web,android,ios
User Testing
TEST_TEH: Using Keyman for Android, type
tehand verify thattheshows up as a suggestion and is autoselected.TEST_TEHRE: Using Keyman for Android, type
tehreand verify thatthereshows up as a suggestion and is autoselected.TEST_FREI: Using Keyman for Android, type
freiand verify thatfriendshows up as a suggestion. (Autoselection is not expected here.)