Repository navigation
fix(golint): say which install.sh cannot install golangci-lint v2.15.0 - #40
Draft
slayerjain wants to merge 1 commit into
Draft
slayerjain wants to merge 1 commit into
slayerjain wants to merge 1 commit into
Conversation
The comment above the golangci-lint install said upstream's install.sh cannot install any version this image can use. That holds only for the copies older than golangci/golangci-lint#6539 (merged to main 2026-05-01, first tagged in v2.12.1): the one on golangci-lint's master branch, which has not moved since March 2025, and those of v2.12.0 and earlier tags. Their unanchored checksum grep also matches the SBOM line each release from v2.12.0 lists, so the verify fails. https://golangci-lint.run/install.sh, which serves main's copy, installs v2.15.0. The comment now says which copy fails (master's) and which works (main's, served by golangci-lint.run), puts the SBOM cut-off at v2.12.0 rather than v2.13.0, and quotes master's grep line exactly. Comments only: the install itself is unchanged. It stays by hand so that no install script is fetched at build time; it makes the same checksum check, matched on the exact filename. Signed-off-by: slayerjain <shubhamkjain@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
keploy-ci-golint/Dockerfile: comments only. The install itself is unchanged.The comment above the golangci-lint install said upstream's
install.sh"cannot install any version we are able to use here". That is true only of the copies older than golangci/golangci-lint#6539:masterbranch, whichraw.githubusercontent.com/golangci/golangci-lint/master/install.shstill serves. master has not moved since March 2025; upstream works onmain.Those copies look the checksum up with an unanchored
grep "${BASENAME}". From v2.12.0, each release's checksums file also lists<tarball>.sbom.json, so that grep matches two lines and the verify fails. #6539 (merged to main 2026-05-01, first tagged in v2.12.1) anchored it asgrep "${BASENAME}$". Main'sinstall.shinstalls v2.15.0. https://golangci-lint.run/install.sh serves that same copy, and so does the v2.15.0 tag.The comment now:
What was checked
https://golangci-lint.run/install.sh,raw.githubusercontent.com/golangci/golangci-lint/main/install.shand.../v2.15.0/install.share byte-identical (sha2561022ddb4...).curl -sSfL https://golangci-lint.run/install.sh | sh -s -- -b <dir> v2.15.0installsgolangci-lint has version 2.15.0 built with go1.27.0 from 25c5369a. That is the same buildgolangci-lint --versionreports inghcr.io/keploy/keploy-ci:golint-1.2.49.err hash_sha256_verify checksum for '.../golangci-lint-2.15.0-linux-arm64.tar.gz' did not verifyfollowed by two hashes..sbom.jsonlines. v2.12.0 through v2.15.0 each have 27, one per binary archive.install.shhas the unanchored grep. v2.12.1's has the anchored one.