VNC-531 Refactor for enhanced uniqueness and consistency. - #211
Open
quickiwiki wants to merge 1 commit into
Open
quickiwiki wants to merge 1 commit into
quickiwiki wants to merge 1 commit into
Conversation
mmcclaskey
requested changes
Aug 31, 2026
| } | ||
| }; | ||
| relayWorker.port.postMessage({type: 'secondary_ready', screenIndex}); | ||
| relayWorker.port.postMessage({type: 'secondary_ready', screenID: this.screenID}); |
Collaborator
There was a problem hiding this comment.
Relay initialization remains tied to every registered index notification. Reindexing screens sends registered again, causing the secondary to open another worker connection. The PR removed the corresponding primary re-registration, leaving a stale pending room for that screenID
| port.onmessage = function (ev) { | ||
| const {type, screenIndex} = ev.data; | ||
| if (typeof screenIndex !== 'number') | ||
| const {type, screenID} = ev.data; |
Collaborator
There was a problem hiding this comment.
The UUID is observable. Secondary registration broadcasts screenID over a channel named solely from the page URL. Any same-origin context can subscribe, learn the UUID, then race secondary_ready. The worker still gives the framebuffer port to the first matching registration, reproducing VNC-531’s interception scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.