Repository navigation
Conversation
The TypeScript rewrite only skips spaces around each range-spec, so a tab (also OWS in RFC 9110) makes the range invalid. 1.2.1 used trim() and accepted it.
Member
|
Thanks, rolled into my existing work in #71. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TypeScript rewrite skips only spaces (char code 32) around each range-spec. RFC 9110 lets a list element be surrounded by OWS, which is SP or HTAB, and 1.2.1 accepted tabs because it used
trim().On master a tab makes that range invalid, so it is dropped or the whole header becomes malformed:
jshttp/fresh made the same change in #77. This adds a small
isOwscheck (SP or HTAB) to the two whitespace loops. Whitespace around the-itself is still rejected, since the grammar does not allow OWS there.Testing: a new spec with tabs before, after and between ranges fails on master (returns
-2) and passes with the fix.npm test(prettier, tsc, vitest with 100% coverage) passes.