Repository navigation
Avoid spurious session errors after listener-initiated disconnect - #784
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #783.
After dispatching a received message to the request listeners, stop the session receive loop if the channel is no longer connected. A listener can deliberately disconnect a client without the next receive generating a misleading
session-error/unconnected ISOChannel.The existing listener return-value contract, final disconnect, server disconnect event, and
SessionEndpath are unchanged. Genuine receive, listener, and cleanup failures remain visible; peer EOF and socket-error handling are unchanged. This does not suppress arbitrary I/O exceptions or eliminate races with unrelated asynchronous disconnects.Regression coverage (eight tests)
Three deterministic regression cases failed against unchanged main, then passed with the fix.
Validation
./gradlew check assemble javadocpassed: 4,472 tests reported, zero failures/errors, 69 skipped. All eight new regression tests passed.An intermediate full run hit the existing
TSpaceTest.testNotifyReaders500 ms timing assertion. The complete TSpaceTest class passed in isolation and the subsequent full check passed without changing or excluding any tests. Validation was on macOS, including a loopback socket exchange; no separate Linux run was performed.