Repository navigation
XRAY-160045 - Use the Maven wrapper in the fix stage - #1425
Draft
Jordanh1996 wants to merge 1 commit into
Draft
Jordanh1996 wants to merge 1 commit into
Jordanh1996 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Jordanh1996
requested a deployment
to
frogbot
September 22, 2026 09:52 — with
GitHub Actions
Waiting
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jfrog-int.atlassian.net/browse/XRAY-160045
Background
A project that commits a Maven wrapper often builds on agents with no system Maven installed — the wrapper is there so that none is needed. On those agents the scan succeeds, but autofix fails with
exec: "mvn": executable file not found in $PATHand no fix pull requests are opened. The only workaround isJF_SKIP_AUTOFIX, which turns the fix stage off entirely.Description
NewMavenPackageHandlerbuilt itsjava.DepTreeParamswithoutUseWrapper, somaven-dep-treeran as plainmvnin the fix stage, while the audit path passes the flag through inRunInstallAndAudit. It now carriesscanDetails.UseWrapper, read with the!= nil && *idiom used elsewhere for optional*boolconfig.Tests
TestNewMavenPackageHandlerUsesWrapper— writes a stubmvnwand asserts the handler execs it; fails without the change.Real
scan-repositoryrun against GitHub and Xray on a wrapper-only Maven project withmvnremoved fromPATH: before, the fix stage fails with the error above and opens no pull requests; after, both stages run./mvnwand the expected fix pull requests are created.🤖 Generated with Claude Code