Repository navigation
Ignore disabled permission grants during ACL checks - #113
Open
francescodifilippo wants to merge 1 commit into
Open
francescodifilippo wants to merge 1 commit into
francescodifilippo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a permission such as Overall/Manage is disabled after being assigned to a role, Folder-based Authorization Strategy can continue granting it.
This change checks whether each assigned permission is enabled when evaluating access. It prevents disabled grants from granting access directly or through implied permissions, while preserving access through enabled broader permissions, including Overall/Administer.
The fix applies to the shared ACL implementation used by global, folder, and agent roles. Existing role configuration is preserved.
Addresses SECURITY-3062 / CVE-2025-24401.
Related: PR #110. This change focuses on authorization-time checks, including permissions disabled after ACL construction, and adds regression coverage.
Testing done
Executed locally with Eclipse Temurin Java 21 and Apache Maven 3.9.16:
mvn verify: all 48 tests passed, with no failures, errors, or skipped tests. HPI packaging and SpotBugs passed.Submitter checklist
Francesco Di Filippo