Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docker-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,8 @@ jobs:
- name: Run Trivy vulnerability scanner
run: |
# Download and run Trivy directly
wget https://github.com/aquasecurity/trivy/releases/download/v0.48.0/trivy_0.48.0_Linux-64bit.tar.gz
tar zxvf trivy_0.48.0_Linux-64bit.tar.gz
wget https://github.com/aquasecurity/trivy/releases/download/v0.69.3/trivy_0.69.3_Linux-64bit.tar.gz
tar zxvf trivy_0.69.3_Linux-64bit.tar.gz
Comment on lines +205 to +206

Copilot AI Apr 2, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Trivy version is duplicated in both the download URL and the tarball filename, which makes future updates error-prone (easy to bump one line and forget the other). Consider defining a single TRIVY_VERSION variable (env or shell var) and interpolating it in both commands.

Suggested change
wget https://github.com/aquasecurity/trivy/releases/download/v0.69.3/trivy_0.69.3_Linux-64bit.tar.gz
tar zxvf trivy_0.69.3_Linux-64bit.tar.gz
TRIVY_VERSION=0.69.3
wget https://github.com/aquasecurity/trivy/releases/download/v${TRIVY_VERSION}/trivy_${TRIVY_VERSION}_Linux-64bit.tar.gz
tar zxvf trivy_${TRIVY_VERSION}_Linux-64bit.tar.gz

Copilot uses AI. Check for mistakes.
Comment on lines +205 to +206

Copilot AI Apr 2, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step downloads and executes a prebuilt Trivy binary without any integrity verification. To reduce supply-chain risk, consider verifying the release checksum/signature (e.g., SHA256SUMS + signature) before extracting/executing, or use a pinned, trusted install method (e.g., the trivy-action or package manager with version pinning).

Copilot uses AI. Check for mistakes.

# Build the image
docker build -t test-scan:latest .
Expand Down
Loading