Repository navigation
ci: move sentinel to 16d991f and add review-mark.yml - #298
Merged
Merged
Conversation
The review app's key moves to the sentinel-review-app environment, which only main can use, and review-mark.yml posts the security-review check from main once a pull request's review has passed.
crenshawdev
force-pushed
the
ci/sentinel-review-env
branch
from
October 26, 2026 00:13
6a21ccc to
b4b1f94
Compare
crenshawdev
changed the title
|
2 findings: 2 low. The full review is encrypted in this run's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the sentinel pin to 16d991f, copies the kit's fast.yml and adds its review-mark.yml.
A pull request from a branch of this repository ran its own copy of fast.yml with the review app's key, so the key could be copied out. The key now lives in the sentinel-review-app environment, which only main can deploy to, and only main's runs read it: review-pr, and review-mark.yml, which posts the security-review check as the app once a pull request's review has passed with main's fast.yml and sentinel pin and targets main. A Dependabot pull request is marked without a review only when Dependabot started every pull request run for its head commit.
Tested on a scratch repo: a normal pull request was marked by review-mark.yml, a pull request whose workflow read the key got an empty value and its environment job was refused, a pull request that edits fast.yml was left for the hand-started review, and a fork-style pull request was marked by review-pr. This pull request changes fast.yml itself, so it is marked with gh workflow run fast.yml -f pr=.