Repository navigation
Pin sentinel at 1b5e34a and take its fast checks - #289
Merged
Merged
Conversation
1b5e34a runs Miri through nextest, so a test Miri cannot run stops only itself instead of the whole binary. The kit's fast.yml adds gitleaks, runs the mechanical job on pushes to main, and no longer holds the review behind it. SECURITY.md said CI runs cargo geiger, the fuzz builds and Miri, but CI installs none of them; they run in the full audit.
|
No findings. The full review is encrypted in this run's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the
.sentinelpin from 34a3c66 to 1b5e34a and copies the kit'sci/fast.ymlover ours. 1b5e34a fixes howcheck.shruns Miri: it now goes through nextest with each test in its own process, so a test Miri can't run stops only that test instead of the whole binary. The newfast.ymladds gitleaks over the full history, runs the mechanical job on pushes tomainas well as pull requests, and dropsneeds: mechanicalfrom the review, so a failing gate no longer skips it.SECURITY.md was wrong about CI. It said the mechanical job reports cargo geiger, the fuzz builds and Miri, but the CI install script installs none of them, so
check.shskips all three there. The section now says what CI actually runs, and the full audit's first step says where geiger, the fuzz builds and Miri do run and how to read Miri's results.No Rust changed. zizmor reports the same single low finding on the new
fast.ymlas on the old one, the pinnednpm installof Claude Code.