Repository navigation
Size build jobs and test threads to each stream's share of the machine - #288
Merged
Merged
Conversation
…x jobs Six jobs left most of the machine idle when one stream built alone, and more streams need room to build side by side. A run now takes the thread count divided by the streams building at once. CI keeps six.
|
No findings. The full review is encrypted in this run's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds and test runs were fixed at six jobs and six test threads. When one stream builds alone that leaves most of the machine idle, and it's the wrong number once several streams build side by side. Now each run takes its share: the machine's thread count divided by the streams building at once.
.cargo/config.tomlgoes away, sincejobs = 6was its only setting, and nextest's default profile moves tonum-cpus. Design 0015's UPK-R11 and its check commands say the same thing. CI is unchanged and still passes six, since it runs one stream on its own runner, and suite measurement under UPK-R10 stays at six so its numbers compare. The host-matrix spike procedures still build with-j 6, and I left them alone.Verified locally at 16 build jobs and 16 test threads on top of #287: 3,813 tests passed, and clippy, fmt and cargo deny are clean.