Repository navigation
CORE-4494: Document response interception - #35
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Explain Playwright response routing through the recording proxy. Cover prefetch timing, cache and service workers, and label mocked proofs. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
Original prompt from Tomasz
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CORE-4494 asks whether Playwright response interception works through the recording proxy. Document that
route.fetch()/route.fulfill()work with page and context routes.Add setup timing, prefetch/client-side cache and service-worker caveats to the existing browser reference. Require mocked responses to be labeled so a UI proof does not imply backend verification.
Review guide
Read
skills/jam-proof/references/browser.md. The main skill links to the guidance, and the changelog records it. The original Next.js failure remains undiagnosed.The CLI bundles a pinned copy of this skill; its bundle needs a resync after merge.
Verification
https://jam.dev/c/3ee49044-e025-42c4-993a-7bfb5159475f
Released CLI 1.35.0 with Chrome 156 and Playwright 1.59.1: direct and proxied page/context routes each fetched origin once and returned modified JSON, status, and header.
node scripts/check.mjs, 47 regression tests, and diff checks passed.Link to Devin session: https://app.devin.ai/sessions/a0a0e8998f22495fb6d3a4e0c4d67dc0
Open in Devin Desktop: https://app.devin.ai/desktop/session/a0a0e8998f22495fb6d3a4e0c4d67dc0?variant=devin
Requested by: @baransu