Skip to content

Properly convert action field to IRI event#744

Merged
lukasfrank merged 2 commits into
mainfrom
fix/ironcore-1489-set-action-field-when-converting-to-iri-event
Jul 9, 2026
Merged

Properly convert action field to IRI event#744
lukasfrank merged 2 commits into
mainfrom
fix/ironcore-1489-set-action-field-when-converting-to-iri-event

Conversation

@friegger

@friegger friegger commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Event listings now include the event action value as part of the ListEvents response payload, making event details complete and consistent across both unfiltered and filtered results.

Signed-off-by: Felix Riegger <felix.riegger@sap.com>
@friegger friegger requested a review from a team as a code owner July 8, 2026 14:19
@friegger friegger requested a review from lukasfrank July 8, 2026 14:19
@github-actions github-actions Bot added size/XS bug Something isn't working labels Jul 8, 2026
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9a8a4a63-8dcb-443c-81e2-8293043606a6

📥 Commits

Reviewing files that changed from the base of the PR and between 0f2b5be and 59b266b.

📒 Files selected for processing (2)
  • internal/controllers/controllers_suite_test.go
  • internal/server/integration/server_integration_suite_test.go
✅ Files skipped from review due to trivial changes (1)
  • internal/server/integration/server_integration_suite_test.go

📝 Walkthrough

Walkthrough

This PR populates EventSpec.Action in ListEvents responses, updates integration tests to assert the new field, and changes two integration test suite image constants to a pinned Gardenlinux KVM reference.

Changes

Event Action field propagation

Layer / File(s) Summary
Populate and verify Action field
internal/server/event_list.go, internal/server/integration/event_list_test.go
convertEventToIRIEvent now sets Action on EventSpec, and ListEvents integration tests assert Action equals SetIgnition in both filter scenarios.

Integration test image pinning

Layer / File(s) Summary
Pin test OS image references
internal/controllers/controllers_suite_test.go, internal/server/integration/server_integration_suite_test.go
Both suite-level osImage constants switch from unpinned latest image references to ghcr.io/ironcore-dev/gardenlinux/gardener:2150.4.0-kvm.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided, so the required template sections and issue reference are missing. Add the required Proposed Changes section with the three bullet points and include the Fixes # issue reference.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: populating the action field when converting events to IRI events.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ironcore-1489-set-action-field-when-converting-to-iri-event

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@friegger friegger added the integration-tests to run integration tests label Jul 8, 2026
lukasfrank
lukasfrank previously approved these changes Jul 9, 2026
Signed-off-by: Lukas Frank <lukas.frank@sap.com>
@lukasfrank lukasfrank merged commit e62053c into main Jul 9, 2026
11 checks passed
@lukasfrank lukasfrank deleted the fix/ironcore-1489-set-action-field-when-converting-to-iri-event branch July 9, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working integration-tests to run integration tests size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants