Repository navigation
Conversation
…irst block eth_getLogs ignored a blockHash filter and returned logs from the latest block, and a fromBlock of 0x0 was passed on as 0, which the range query reads as the tip. Query the given block when blockHash is set (rejecting it together with fromBlock/toBlock), and start log ranges at block 1 when the start is 0.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eth_getLogs ignored a blockHash filter and returned logs from the latest
block, and a fromBlock of 0x0 was passed on as 0, which the range query
reads as the tip. Query the given block when blockHash is set (rejecting
it together with fromBlock/toBlock), and start log ranges at block 1 when
the start is 0.
Test:
api/web3server_test.gocovers the change and fails without it.go test -gcflags=all=-N -l -shortpasses for the touched packages.