feat(firestore): variable() and arrayFilter() API features for pipelines

[russellwheatley]

Description

Adds Firestore Pipeline expression APIs and native lowering for variable(), arrayFilter(), arrayFirst, arrayFirstN, and related array helpers, plus iOS bug fixes found during e2e verification.

Features

• arrayFilter() in the JS pipeline builder and public exports
• variable() across TypeScript, web/macOS reconstruction, Android, and iOS lowering
• arrayFirst, arrayFirstN, arrayLastN, arraySlice, arrayMaximumN, arrayMinimumN native lowering (Android + iOS)
• Removed implemented APIs from compare-types missing backlog

Bug fixes (iOS pipeline native)

• Normalize findNearest distanceMeasure to EUCLIDEAN / COSINE / DOT_PRODUCT for FIRFindNearestStageBridge (lowercase values caused invalid-argument)
• Export nor and coerce xor / nor through boolean-expression lowering like and / or
• Parse count_if aggregate predicates from expr or args[0]
• Preserve Bool / CFBoolean in constant bridging; avoid treating boolean NSNumber as integers
• Tag integer constants with integerLiteral in JS and coerce via numericOperand on iOS so 0/1 are not bridged as booleans in arithmetic and ordering comparisons
• Remove arrayFirst / arrayFirstN from iOS unsupported-function guard (now lowered natively)

Tests & infra

• Expanded Pipeline.e2e.js coverage (99 passing on iOS and Android against cloud pipelines-e2e)
• Vector index + deploy docs for pipeline e2e database
• Parity unit tests for array slice and boolean iOS lowering

Related issues

Release Summary

Firestore Pipelines: variable(), arrayFilter(), array helper expressions, and iOS pipeline coercion fixes for booleans, integers, nor, count_if, and findNearest.

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
  • Other (macOS, web)
• My change includes tests;
  • e2e tests added or updated in packages/**/e2e
  • jest tests added or updated in packages/**/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

• yarn tests:jest packages/firestore/__tests__/pipelines-parity.test.ts
• iOS Detox pipeline e2e (scoped): 99 passing (yarn tests:ios:test-reuse)
• Android Detox pipeline e2e (scoped): 99 passing (yarn tests:android:test-cover-reuse)
• Cloud pipelines-e2e vector index deployed; findNearest e2e passes

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the Firestore pipeline capabilities by adding support for variable expressions and array filtering. These additions allow developers to perform more advanced queries and data transformations directly within pipelines. The changes include updates to the core library, native bridge implementations for both Android and iOS, and updated type definitions to support the new API surface.

Highlights

• New API Features: Introduced variable() and arrayFilter API features for Firestore pipelines, enabling more complex data manipulation.
• Cross-Platform Implementation: Implemented support for these new features across TypeScript, Android (Java), and iOS (Swift) to ensure consistent behavior.
• Testing and Validation: Added comprehensive unit, type, and end-to-end tests to verify the new pipeline operations and serialization logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for variable expressions and the arrayFilter function within Firestore pipelines across Android, iOS, and Web platforms. The changes include updates to the serialization and parsing logic in native code, the addition of new TypeScript interfaces and helper functions, and comprehensive testing including unit, type, and E2E tests. A review comment suggests refining the return type of the variable function to VariableExpression to enhance type safety and maintain consistency with the Firebase JS SDK.

[mikehardy]

iOS fails surprisingly not flakes

             evaluates array helpers and array predicates:
     Error: pipelineExecute() does not support these functions on iOS yet: arrayFirst, arrayFirstN.

[github-actions]

Hello 👋, this PR has been opened for more than 14 days with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 7 days until this gets closed automatically

[mikehardy]

have this one about ready locally but other priorities while it went stale 🤦

[codecov]

Codecov Report

❌ Patch coverage is 90.47619% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.43%. Comparing base (ef89d7b) to head (7fedf77).
⚠️ Report is 52 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9017      +/-   ##
==========================================
+ Coverage   60.70%   63.43%   +2.74%     
==========================================
  Files         239      288      +49     
  Lines       11586    14701    +3115     
  Branches     2774     3128     +354     
==========================================
+ Hits         7032     9324    +2292     
- Misses       4444     5318     +874     
+ Partials      110       59      -51     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mikehardy]

firestore pipeline nearest and firestore transaction failures on other noted - will investigate