Add SoC model matching via device tree for ARM/Qualcomm platforms - #584
Add SoC model matching via device tree for ARM/Qualcomm platforms#584priyjain1 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds ARM/Qualcomm-oriented platform selection by matching a platform entry against the device tree board model string, allowing thermald to choose an appropriate thermal configuration when DMI identifiers aren’t available.
Changes:
- Extend parsed platform metadata with a new
soc_modelfield. - Parse a new
<SoCModel>XML element and match it (prefix match) against/sys/firmware/devicetree/base/modelduring platform detection. - Add a sample Qualcomm platform entry using
<SoCModel>inthermal-conf.xml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/thd_parse.h | Adds soc_model field to thermal_info_t to store <SoCModel> from XML. |
| src/thd_parse.cpp | Parses <SoCModel>, logs it in dumps, and adds device-tree model prefix matching in platform_matched(). |
| data/thermal-conf.xml | Introduces an example <Platform> using <SoCModel> for Qualcomm device-tree-based matching. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Some comments by copilot review |
Add support for platform-specific thermal configuration matching using the device tree model string, enabling thermald to apply the correct thermal rules on ARM/Qualcomm SoCs. A new <SoCModel> XML element is introduced in thermal-conf.xml Platform entries. During platform matching, thermald reads the board model string from /sys/firmware/devicetree/base/model and performs a prefix match against the configured SoCModel value. Changes in v2: - Add XML documentation for SocModel. - Address review comments on logging and code style. Signed-off-by: Priyansh Jain <priyansh.jain@oss.qualcomm.com>
2c3972f to
0c7f0fb
Compare
Thanks, Addressed all review comments and force-pushed the updated commit. |
|
Please fix these errors. You can do "make clang-tidy" to reproduce: 5256 warnings generated. |
|
These are after applying commits from both PULL requests |
Thank you for the feedback! I have addressed all three clang-tidy warnings and uploaded v3:
The updated patch is available at: a3fb0d1 I have verified with Please let me know if there is anything else to address. |
|
Applied. Thanks! |
Add support for platform-specific thermal configuration matching using the device tree model string, enabling thermald to apply the correct thermal rules on ARM/Qualcomm SoCs.
A new XML element is introduced in thermal-conf.xml Platform entries. During platform matching, thermald reads the board model string from /sys/firmware/devicetree/base/model and performs a prefix match against the configured SoCModel value.