Repository navigation
Conversation
…uments Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012yJAPp4FSD4wtuXkuaKHBq
davidheff
force-pushed
the
fix-anonymous-type-parsing
branch
from
October 9, 2026 01:52
97d3b15 to
6b29b5c
Compare
cirras
self-requested a review
October 9, 2026 05:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SonarDelphi fails to parse two constructs that the Delphi compiler accepts:
Each fails with "no viable alternative", and the whole file drops out of analysis.
Changes:
recordVariantTagaccepts an anonymous enum or subrange type as well as a type reference.SymbolTableVisitoralready handles anonymous enums in variant tags throughhandleVarDeclaration, so the enum elements are declared and resolve.genericArgumentsaccepts anonymous array, set and procedural types, all of whichNameResolutionHelper.resolve(TypeNode)already handles.Scope, checked against Delphi 11: the compiler also accepts anonymous pointer (
TArray<^Integer>)and enum (
TArray<(a, b)>) generic arguments. I've left those out because a leading^overlapswith caret-escaped character literals (#111),
<(is ambiguous with a comparison in expressions,and an anonymous enum there would need its elements declared from inside a generic argument list.
I'm happy to follow up if you'd like them covered.
Tests: grammar tests for both constructs, plus symbol table tests showing that anonymous tag enum
elements resolve and that type references inside an anonymous array generic argument resolve. The
full
delphi-frontendanddelphi-checkssuites pass.🤖 Generated with Claude Code