Init command with linting to support collector - #93
Merged
Conversation
morningspace
left a comment
morningspace
left a comment
Collaborator
There was a problem hiding this comment.
As it's still in early stage, instead of having this merged to main, we may need to bring all these changes to a separate branch, e.g.: fi-features.
| }); | ||
|
|
||
| // Check for Python collector file (should end with _collector.py) | ||
| const pythonCollectorFiles = files.filter(file => file.endsWith('_collector.py')); |
Collaborator
There was a problem hiding this comment.
We do not have such restriction yet. Let's remove the suffix check.
| } | ||
|
|
||
| // Print all found files in one line | ||
| if (foundFiles.length > 0) { |
Collaborator
There was a problem hiding this comment.
Not sure whether it's needed. There could be recursive folders and files under collector, which we do not restrict yet.
| readmeContent += ` | ||
| ## Collector | ||
|
|
||
| Below are the collector configurations that are currently supported by this integration package. |
Collaborator
There was a problem hiding this comment.
What does the "collector configurations" mean?
| const targetDir = path.join(packagePath, 'collector'); | ||
|
|
||
| // Dockerfile | ||
| const dockerfileContent = `# Multi-stage build for Python collector |
Collaborator
There was a problem hiding this comment.
Instead of inlining these template files into CLI, we probably need to put them in a separate place.
morningspace
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.