Skip to content

fix: DefaultChainClient::wait_for_blocks bug #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hu55a1n1 merged 1 commit into from
Dec 11, 2025
Merged

fix: DefaultChainClient::wait_for_blocks bug #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions crates/enclave/core/src/chain_client/default.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,23 +172,19 @@ impl ChainClient for DefaultChainClient {
.await
}

async fn wait_for_blocks(&self, blocks: u8) -> Result<(), Self::Error> {
async fn wait_for_blocks(&self, mut blocks: u8) -> Result<(), Self::Error> {
debug!("Waiting for {} blocks", blocks);
let (client, driver) = WebSocketClient::new(self.ws_url.to_string().as_str()).await?;

let (client, driver) = WebSocketClient::new(self.ws_url.to_string().as_str()).await?;
let driver_handle = tokio::spawn(async move { driver.run().await });

// Subscription functionality
let mut subs = client.subscribe(EventType::NewBlock.into()).await?;

// Wait 2 NewBlock events
let mut ev_count = 2_i32;

while let Some(res) = subs.next().await {
let _ev = res?;
ev_count -= 1;
trace!("Received new block event, {} remaining", ev_count);
if ev_count == 0 {
blocks -= 1;
trace!("Received new block event, {} remaining", blocks);
if blocks == 0 {
break;
}
}
Expand Down
Loading