Repository navigation
Conversation
The highlight of the hovered option was only inset horizontally, so hovering the first or last option painted over the top or bottom border of the menu. Fixes iced-rs#3534.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3534.
The highlight of the hovered option in
overlay::menuwas only inset horizontally by the border width, so hovering the first or the last option painted over the top or bottom border of the menu. It shows with the default theme too.The highlight is now clipped to the visible menu area inside its top and bottom borders. Clipping against the viewport (instead of special-casing the first and last options) also covers a scrolled menu, where a partially visible option sits under a border.
I checked it with a small
iced_testsnapshot (tiny-skia backend, 2px black menu border) that counts the border rows in one pixel column: before, hovering the first, the last, or a half-scrolled option left only one border visible; after, both stay visible in all cases.cargo test -p iced_widgetand clippy are clean.