Fix manifest.json artifact upload in workflow - #1771
Merged
EnriqueL8 merged 3 commits intoSep 22, 2026
Merged
Conversation
Signed-off-by: Daniel Raper <daniel.raper@kaleido.io>
EnriqueL8
reviewed
Aug 5, 2026
| uses: actions/upload-release-asset@v1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| uses: softprops/action-gh-release@v3 |
Contributor
There was a problem hiding this comment.
what is softprops? Why are we not using the official actions?
Contributor
Author
There was a problem hiding this comment.
Its recommended by the GitHub team as a replacement for the discontinued action https://github.com/actions/upload-release-asset
Please note: This repository is currently unmaintained by a team of developers at GitHub. The repository is here and you can use it as an example, or in Actions. However please be aware that we are not going to be updating issues or pull requests on this repository.
Maintained Actions:
EnriqueL8
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes workflow permissions to allow writing artifacts.
Also fixes leading comma issue and replaces the deprecated workflow.