Skip to content

fix(ffresty): Set the correct maxIdleConnHosts value and idleTimeout - #250

Merged
EnriqueL8 merged 2 commits into
hyperledger-firefly:mainfrom
kaleido-io:ffresty-max-idle-conns-per-host
Sep 7, 2026
Merged

fix(ffresty): Set the correct maxIdleConnHosts value and idleTimeout#250
EnriqueL8 merged 2 commits into
hyperledger-firefly:mainfrom
kaleido-io:ffresty-max-idle-conns-per-host

Conversation

@onelapahead

Copy link
Copy Markdown
Contributor

Fixes two different typos that affect HTTP client performance by default:

  1. we meant for the idle timeout to be <5s , but not less than 500ms. Meaning we essentially don't re-use connections unless theres constant requests
  2. we were setting maxidleconnsperhost == maxconnsperhost, so it wasn't actually being set to 100, meaning it kept using Go's conservative default of 2 (which I tried to fix in [ffresty] maxIdleConnsPerHost Setting #154 originally)

Signed-off-by: hfuss <hayden.fuss@kaleido.io>
@onelapahead
onelapahead requested a review from a team as a code owner September 5, 2026 22:13
Signed-off-by: hfuss <hayden.fuss@kaleido.io>

@EnriqueL8 EnriqueL8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these @onelapahead !

@EnriqueL8
EnriqueL8 merged commit 296d6fc into hyperledger-firefly:main Sep 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants