Conversation
…ransaction fee: the connector fills cum_fees_quote with what the open and close cost on-chain and puts the fee income in custom_info.fees_earned_quote, so the one number that says whether a band is worth keeping read three orders of magnitude low — a live DJT-USDC band showed $0.000023 against $0.074624 actually earned; the formatter now prefers fees_earned_quote when the executor carries it and falls back to cum_fees_quote for executors that have no custom_info twin
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…e direction An LP executor without custom_info.fees_earned_quote fell back to cum_fees_quote, which for an LP is the on-chain transaction cost — so the detail view could still show a cost as fee income, the confusion this branch exists to fix. LP now reads fees_earned_quote only; when the field is absent the income is unknown and no fee line is printed. Non-LP executors keep their cum_fees_quote, labelled "Fees Paid" so a client cannot read a paid fee as income against the LP's "Fees Earned".
lgrawet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show an LP executor's earned fees in its detail view instead of the transaction fee fee: the connector fills cum_fees_quote with what the open and close cost on-chain and puts the fee income in custom_info.fees_earned_quote, so the one number that says whether a band is worth keeping read three orders of magnitude low — a live DJT-USDC band showed $0.000023 against $0.074624 actually earned; the formatter now prefers fees_earned_quote when the executor carries it and falls back to cum_fees_quote for executors that have no custom_info twin