Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--timeout, so the stage limit only killed the host-sidedocker exec. The tests kept running in the shared container, and the next stage failed withprecleanup_failed(moto: 193 stage logs alternate between a 600 s timeout andprecleanup_failed). The launcher now gets the stage budget minus a margin for reset, rebuild and purge, so it stops and cleans up the tests itself./procsweep, because slim images have nopkill.Test plan
--timeout, the budget split, and the kill on a client-side timeout. They fail onmain.timeoutin about 34 s, and the next stage runs clean. Without a limit, the client-side timeout leaves no test-user process running.test_validate_stage_script,test_pipeline_pr_runtime,test_ungraded_sites(106 passed),ruff check,ruff format --check.Out of scope
A fresh container per stage (RFC per #253). Part of #253 (phase 0).