Repository navigation
Fix RolesAuthority storage collision bug - #145
Merged
Merged
Conversation
kadenzipfel
force-pushed
the
fix/roles-collision
branch
from
July 6, 2026 18:10
586690e to
2864688
Compare
Contributor
|
+1 |
Maddiaa0
approved these changes
Sep 30, 2026
Maddiaa0
added a commit
that referenced
this pull request
Sep 30, 2026
Resolve the RolesAuthority conflict with #145. Keep this branch's hash-once slot handling, but compute capability slots with their storage locations via MAPPING_SLOT_2D, so isCapabilityPublic and getRolesWithCapability stay in separate mappings. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, both
GET_ROLE_FOR_CAPABILITYandIS_CAPABILITY_PUBLICwere deriving the same storage slot,keccak256(target‖sig), so they would overwrite each other. Fix is to use the previously unusedIS_CAPABILITY_PUBLIC_LOCATIONandGET_ROLES_WITH_CAPABILITY_LOCATIONstorage pointer constantsI could not find any production deployments containing this bug, so appears safe to disclose