Repository navigation
fix: handle value=None in DateRangeSlider._sync_values - #8901
Merged
philippjfr merged 2 commits intoOct 23, 2026
Merged
Conversation
2 tasks done
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8901 +/- ##
==========================================
- Coverage 89.79% 89.71% -0.09%
==========================================
Files 406 406
Lines 69094 69118 +24
==========================================
- Hits 62046 62011 -35
- Misses 7048 7107 +59 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Assigning
DateRangeSlider.value = Noneraises aTypeErrorin_sync_values(panel/widgets/slider.py:785):DateRangeSliderinitializes withvalue = Nonewhen bounds are not yet supplied, and_process_param_changealready handlesvalue is Noneby deleting'value'from model properties before sending them to Bokeh. However,_sync_valuesattempted to unpackself.valueunconditionally whenevervaluechanged.This patch updates
_sync_valuesto check whetherself.value is None. WhenNone, it updatesvalue_startandvalue_endtoNone. When non-None, it unpacks the tuple as before. It also removes the unusedallow_None=Falseargument on theparam.DateRangedeclaration, which was overridden by Param becausedefault=None.Fixes #8871
I added two unit regression tests to
panel/tests/widgets/test_slider.py:test_date_range_slider_value_none: verifies settingDateRangeSlider.value = Noneupdatesvalue_startandvalue_endtoNonewithout raising, and allows subsequent tuple re-assignment.test_datetime_range_slider_value_none: verifies the same behavior onDatetimeRangeSlider.Both tests fail with
TypeErroron unchanged main and pass with this change. The complete slider test suite (pytest panel/tests/widgets/test_slider.py) passes with 84 passing tests.Checklist