Repository navigation
executor: reject actions requesting a non-Linux OSFamily - #52
Merged
Merged
Conversation
actiond only runs Linux actions, but it ignored the standard REAPI OSFamily platform property. An action routed to actiond with OSFamily=macos was accepted and then failed at exec inside the Linux guest. Reject such actions before any sandbox setup with a FAILED_PRECONDITION ExecuteResponse. Matching is case-insensitive because clients commonly send "Linux" rather than the lexicon value "linux"; actions without OSFamily are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actiond only runs Linux actions, but it ignored the standard REAPI
OSFamilyplatform property. An action routed to actiond withOSFamily=macos(for example from a mixed Linux/macOS Bazel build) was accepted and then failed atexecinside the Linux guest.This rejects such actions right after the execution platform is resolved, before input validation or any sandbox setup, and reports them as a completed operation with
FAILED_PRECONDITIONand a readable message (same path asSandboxSetupFailedand timeouts), instead of a late exec failure.linux, but many client configs sendLinux, and those work today.OSFamily, or with an empty value, are unaffected.Testing
bazel test //src:unit_testson macOS arm64 (210/210), including:validateOsFamily accepts Linux and rejects other OS familiesexecuteDecodedActionWithOptions rejects non-Linux OSFamily before creating directoriesexecution infrastructure failures become uncached completed operationsmapping testbazel build //.../bazel test //...(needs--config=remote) andtools/e2e.sh vm.