Repository navigation
Add private Download all ZIP for task attachments - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks with multiple saved attachments now offer Download all (ZIP) next to Add image / PDF / file. The private download includes each original once, including comment attachments, with safe filenames and numbered duplicates.
The browser and MCP share the canonical attachment list and download path:
list_attachmentsreturns an authenticateddownloadPath, keeping binary data out of tool context. ZIP entries stream sequentially from R2 with backpressure and size/SHA-256 verification; missing/corrupt files abort the archive. Read-only users retain download access. No schema migration or persistent archive copies.Validation: typecheck, production build, UI tests, browser/OAuth authorization and cross-owner denial, ZIP byte/CRC verification, duplicate/unsafe filenames, corrupt/missing files, cancellation, metadata and deployment guard tests. All other suites passed; the large-file workerd test now passes with a 105 MiB ZIP containing a 100 MiB original. CI reruns the full suite before merge and production deployment.
Closes #28.