Skip to content

UofT-DSI | Python - Assignment 2 - #2

Open
hayun120 wants to merge 2 commits into
mainfrom
assignment-2
Open

UofT-DSI | Python - Assignment 2#2
hayun120 wants to merge 2 commits into
mainfrom
assignment-2

Conversation

@hayun120

Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Added completed python code for assignment 2, including reading and displaying the csv files, writing the patient_summary function, and implementing the detect_problems function to flag any patients with a mean inflamm score of 0.

What did you learn from the changes you have made?

I learned how to use NumPy to efficiently summarize 2D array data by specifying an axis, which is where I was confused at first because I did not set the axis to 1, which resulted in the average across all patients rather than for each patient. I also learned how to embed one function within another.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Another approach would have been to loop through each row manually and compute the summary statistic using python methods like sum()/len(row) for mean. However, NumPy's functions seem to be more efficient and widely used.
For reading the file, readline(), as suggested by the assignment text, could have also been used; but I chose to use readlines() because it loads all rows at once into a list that's easy to iterate over.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Again, the main challenge for me was understanding the axis parameter in NumPy. I suppose it wasn't clear during class whether axis=0 or 1 was correct. I worked through it by considering the shape of the data: 60 rows (patients) by 40 columns (days), and recognizing that to get one value per patient, the operation needs to be collapsed across the columns, which means axis=1.

How were these changes tested?

Tested through the code provided in the assignment.

A reference to a related issue in your repository (if applicable)

N/A

Checklist

  • I can confirm that my changes are working as intended

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants