UofT-DSI | Python - Assignment 2 - #2
Open
hayun120 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Added completed python code for assignment 2, including reading and displaying the csv files, writing the patient_summary function, and implementing the detect_problems function to flag any patients with a mean inflamm score of 0.
What did you learn from the changes you have made?
I learned how to use NumPy to efficiently summarize 2D array data by specifying an axis, which is where I was confused at first because I did not set the axis to 1, which resulted in the average across all patients rather than for each patient. I also learned how to embed one function within another.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Another approach would have been to loop through each row manually and compute the summary statistic using python methods like sum()/len(row) for mean. However, NumPy's functions seem to be more efficient and widely used.
For reading the file, readline(), as suggested by the assignment text, could have also been used; but I chose to use readlines() because it loads all rows at once into a list that's easy to iterate over.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Again, the main challenge for me was understanding the axis parameter in NumPy. I suppose it wasn't clear during class whether axis=0 or 1 was correct. I worked through it by considering the shape of the data: 60 rows (patients) by 40 columns (days), and recognizing that to get one value per patient, the operation needs to be collapsed across the columns, which means axis=1.
How were these changes tested?
Tested through the code provided in the assignment.
A reference to a related issue in your repository (if applicable)
N/A
Checklist